[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno marked 3 inline comments as done.
riccibruno added inline comments.


================
Comment at: include/clang/AST/Expr.h:5084
+  /// storage of Stmt * and TypeSourceInfo * in GenericSelectionExpr.
+  template <bool Const> class AssociationIteratorTy {
+    friend class GenericSelectionExpr;
----------------
aaron.ballman wrote:
> riccibruno wrote:
> > dblaikie wrote:
> > > Worth using any of the iterator helpers LLVM has? (iterator_facade or the like)
> > I did try to use `iteratore_facade` but for some reason I was getting strange overload resolution failures with it.
> > 
> > In the end it did not save much and so I just rewrote the boiler-plate (especially given that if we end up going with an input iterator there is not going to be much boiler-plate).
> Does using the `iterator_facade_base` help now that we're back to an input iterator? It seems like that should be able to get rid of some of the boilerplate.
I must be holding it wrong; for some reason the post-fix operator ++ is not getting found when I use `iterator_facade_base`. It also forces me to define `operator==` as a member instead of a non-member function. Do you mind terribly if I don't use it ? It only at best avoid me to write `operator!=` and `operator++(int)`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57106/new/

https://reviews.llvm.org/D57106