[libunwind] r352245 - [libunwind] Use placement new to avoid dependency C++ library
Petr Hosek via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 25 13:39:46 PST 2019
Author: phosek
Date: Fri Jan 25 13:39:46 2019
New Revision: 352245
URL: http://llvm.org/viewvc/llvm-project?rev=352245&view=rev
Log:
[libunwind] Use placement new to avoid dependency C++ library
The rest of libunwind already uses placement new, these are the only
places where non-placement new is being used introducing undesirable
C++ library dependency.
Differential Revision: https://reviews.llvm.org/D57251
Modified:
libunwind/trunk/src/libunwind.cpp
Modified: libunwind/trunk/src/libunwind.cpp
URL: http://llvm.org/viewvc/llvm-project/libunwind/trunk/src/libunwind.cpp?rev=352245&r1=352244&r2=352245&view=diff
==============================================================================
--- libunwind/trunk/src/libunwind.cpp (original)
+++ libunwind/trunk/src/libunwind.cpp Fri Jan 25 13:39:46 2019
@@ -14,8 +14,6 @@
#ifndef NDEBUG
#include <cstdlib> // getenv
#endif
-#include <new>
-#include <algorithm>
#include "libunwind_ext.h"
#include "config.h"
@@ -122,12 +120,14 @@ static bool is64bit(task_t task) {
_LIBUNWIND_EXPORT unw_addr_space_t unw_create_addr_space_for_task(task_t task) {
#if __i386__
if (is64bit(task)) {
- unw_addr_space_x86_64 *as = new unw_addr_space_x86_64(task);
+ unw_addr_space_x86_64 *as = malloc(sizeof(unw_addr_space_x86_64));
+ new (as) unw_addr_space_x86_64(task);
as->taskPort = task;
as->cpuType = CPU_TYPE_X86_64;
//as->oas
} else {
- unw_addr_space_i386 *as = new unw_addr_space_i386(task);
+ unw_addr_space_i386 *as = malloc(sizeof(unw_addr_space_i386));
+ new (as) unw_addr_space_i386(task);
as->taskPort = task;
as->cpuType = CPU_TYPE_I386;
//as->oas
@@ -144,18 +144,21 @@ _LIBUNWIND_EXPORT void unw_destroy_addr_
#if __i386__ || __x86_64__
case CPU_TYPE_I386: {
unw_addr_space_i386 *as = (unw_addr_space_i386 *)asp;
- delete as;
+ as->~unw_addr_space_i386();
+ free(as);
}
break;
case CPU_TYPE_X86_64: {
unw_addr_space_x86_64 *as = (unw_addr_space_x86_64 *)asp;
- delete as;
+ as->~unw_addr_space_x86_64();
+ free(as);
}
break;
#endif
case CPU_TYPE_POWERPC: {
unw_addr_space_ppc *as = (unw_addr_space_ppc *)asp;
- delete as;
+ as->~unw_addr_space_ppc();
+ free(as);
}
break;
}
More information about the cfe-commits
mailing list