[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 🙈

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tidy/google/FunctionNamingCheck.cpp:96-97
 
   // Match function declarations that are not in system headers and are not
   // main.
   Finder->addMatcher(
----------------
This comment is drifting more and more out of sync with the code.


================
Comment at: test/clang-tidy/google-objc-function-naming.m:5-8
+static void TestImplicitlyDefinedFunction(int a) {
+  printf("%d", a);
+}
+
----------------
Excuse my ignorance, but I don't see what about this function definition is testing an implicitly-defined function. Doesn't the `#import` above bring in the declaration for `printf()`, while `TestImplicitlyDefinedFunction()` itself is explicitly defined?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57207/new/

https://reviews.llvm.org/D57207