[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 25 10:54:37 PST 2019


lebedev.ri added inline comments.


================
Comment at: test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp:2
+// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target aarch64-linux-gnu -I %S
+
+#include "readability-uppercase-literal-suffix.h"
----------------
Targets can be disabled in cmake
This needs something like `// REQUIRES: aarch64`.
And yes, the tests that hardcoded x86 should require x86 too.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57249/new/

https://reviews.llvm.org/D57249





More information about the cfe-commits mailing list