[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 25 09:02:31 PST 2019


balazske added inline comments.


================
Comment at: unittests/AST/ASTImporterTest.cpp:2523
+  Decl *ToTU = ToAST->getASTContext().getTranslationUnitDecl();
+  cast<DeclContext>(ToTU)->dumpDeclContext();
+  ASSERT_EQ(DeclCounter<FunctionDecl>().match(ToTU, functionDecl(hasName("f"))),
----------------
Is this dump needed? (The test should not write unnecessary text output. But debug statements can be leaved in the test, possibly in comment.)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57232/new/

https://reviews.llvm.org/D57232





More information about the cfe-commits mailing list