[PATCH] D57185: [clang-tidy] Add the abseil-duration-addition check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 25 08:10:06 PST 2019


JonasToth added inline comments.


================
Comment at: test/clang-tidy/abseil-duration-addition.cpp:84
+#undef PLUS_FIVE
+}
----------------
hwright wrote:
> JonasToth wrote:
> > a view template test-cases would be good to have.
> I'm not sure I know that terminology; do you have an example?
```
template<typename T>
void foo(absl::Time t) {
  int i = absl::ToUnixNanos(t) + T{};
}
foo<int>(t);
foo<double>(t);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57185/new/

https://reviews.llvm.org/D57185





More information about the cfe-commits mailing list