[PATCH] D56936: Fix handling of overriden methods during ASTImport

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 25 01:49:32 PST 2019


balazske added inline comments.


================
Comment at: unittests/AST/ASTImporterTest.cpp:2312
+      cxxMethodDecl(hasName("f"), hasParent(cxxRecordDecl(hasName("B"))));
+  auto BFPIsDefP = cxxMethodDecl(
+      hasName("f"), hasParent(cxxRecordDecl(hasName("B"))), isDefinition());
----------------
Looks mainly OK now. Only a small problem, I do not like names like `BFPIsDefP` here and later, in the previous test it is correctly named `BFDefP` (could be `BFIsDefP` too).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56936/new/

https://reviews.llvm.org/D56936





More information about the cfe-commits mailing list