[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class
Jonas Toth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 25 00:27:54 PST 2019
JonasToth marked 2 inline comments as done.
JonasToth added a comment.
Reverted the changes. Maybe the comma thingie will just stay as is ;)
================
Comment at: clang-tidy/utils/ExceptionAnalyzer.h:25
+/// give the possibility of an exception.
+class ExceptionAnalyzer {
+public:
----------------
lebedev.ri wrote:
> What is the test plan for this utility class, BTW?
> Ensuring that the main user (`bugprone-exception-escape`) has sufficiently full test coverage?
Simplify code first, generate a trace, use it in other context (modernize-patch you have seen already).
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57100/new/
https://reviews.llvm.org/D57100
More information about the cfe-commits
mailing list