[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 24 23:31:20 PST 2019


lebedev.ri added a comment.

To me, modulo the `"IgnoredExceptions"` change, this seems like a straight-forward refactoring.



================
Comment at: clang-tidy/utils/ExceptionAnalyzer.h:25
+/// give the possibility of an exception.
+class ExceptionAnalyzer {
+public:
----------------
What is the test plan for this utility class, BTW?
Ensuring that the main user (`bugprone-exception-escape`) has sufficiently full test coverage?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57100/new/

https://reviews.llvm.org/D57100





More information about the cfe-commits mailing list