[PATCH] D57064: [Sema] Improve a -Warray-bounds diagnostic

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 24 15:51:04 PST 2019


erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.


================
Comment at: clang/include/clang/AST/ASTContext.h:2092
+  Optional<CharUnits> getTypeSizeInCharsIfKnown(QualType Ty) const {
+    if (Ty->isIncompleteType() || Ty->isDependentType())
+      return None;
----------------
aaron.ballman wrote:
> Can you add a dependent type test as well?
I don't think its possible to get a dependent type here, since this feature is only supported in C mode.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57064/new/

https://reviews.llvm.org/D57064





More information about the cfe-commits mailing list