[PATCH] D56936: Fix handling of overriden methods during ASTImport

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 24 14:45:10 PST 2019


shafik added a comment.

@martong so I just tested your `lit-tests.patch` and it looks good!



================
Comment at: lib/AST/ASTImporter.cpp:2959
+}
+
 ExpectedDecl ASTNodeImporter::VisitFunctionDecl(FunctionDecl *D) {
----------------
balazske wrote:
> Code formatting is not OK in this function (and other places). (Indentation and spaces around "(" ")".)
Apologies, I forgot to run clang-format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56936/new/

https://reviews.llvm.org/D56936





More information about the cfe-commits mailing list