[PATCH] D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.
Erik Pilkington via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 24 12:41:18 PST 2019
erik.pilkington added inline comments.
================
Comment at: clang/lib/AST/Type.cpp:1295
+
+ QualType VisitObjCObjectType(const ObjCObjectType *objType) {
+ if (!objType->isKindOfType())
----------------
Does this works with type sugar? i.e. previously calling `Ty->getAs<ObjCObjectType>()` would have stripped through `TypedefType`, but its not obvious to me that this traversal is doing the right thing for that case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57075/new/
https://reviews.llvm.org/D57075
More information about the cfe-commits
mailing list