[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 24 10:13:20 PST 2019
thakis added inline comments.
================
Comment at: lib/Basic/FileManager.cpp:295
+ llvm::sys::path::remove_dots(AbsPath, /*remove_dot_dot=*/true);
+ UFE.RealPathName = AbsPath.str();
+ }
----------------
Should this call fillRealPathName() (which was added after your change)?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57165/new/
https://reviews.llvm.org/D57165
More information about the cfe-commits
mailing list