[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

Rui Ueyama via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 24 09:24:15 PST 2019


ruiu added a comment.

In D56554#1357385 <https://reviews.llvm.org/D56554#1357385>, @mgorny wrote:

> @ruiu, what do you think? The current logic forces some precedence, i.e. if you pass `-z nognustack`, further `-z {no,}execstack` are ignored. I suppose we could just force passing `-z nognustack` as last option clang-wise.


Are you asking about making the flag tri-state? If so, I think it logically makes sense and feels more natural to represent it with two boolean flags. As you said, the last one should always takes precedence over the others among the three flags.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56554/new/

https://reviews.llvm.org/D56554





More information about the cfe-commits mailing list