[PATCH] D57150: [HeaderSearch] don't immediately request that headers are opened in getFileAndSuggestModule().

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Sigh, this regresses perf by 6%ish in my testing (building HeaderSearch.cpp with -fsyntax-only and a cold disk cache).
I think we'll need a more targeted fix: probably passing openFile=false only in the using-PCH case.

Plan for now is to revert the original change, live with the things that are broken, cherrypick the revert to the llvm8 branch, then revisit.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57150/new/

https://reviews.llvm.org/D57150