[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

[Jonas Toth via Phabricator via cfe-commits]

JonasToth marked 3 inline comments as done.
JonasToth added inline comments.


================
Comment at: clang-tidy/bugprone/ExceptionEscapeCheck.cpp:35
+  std::vector<std::string> FunctionsThatShouldNotThrowVec =
+      utils::options::parseStringList(RawFunctionsThatShouldNotThrow);
   FunctionsThatShouldNotThrow.insert(FunctionsThatShouldNotThrowVec.begin(),
----------------
lebedev.ri wrote:
> JonasToth wrote:
> > lebedev.ri wrote:
> > > Does it also accept ',' delimitter?
> > > If not, i'm not sure how good of an idea it is to break existing configs..
> > No it doesn't. It is a breaking change but at the same time it is inconsistent and duplicated functionality.
> > Should be mentioned in release notes, that for sure.
> The thing is, if said list was set (as in user-specified to non-empty), it will be impossible
> to use that same .clang-tidy config with clang-tidy <=8 and trunk.
> I'm personally not affected, but if i was, i wouldn't think this is a great idea..
> 
> Can you at least make the breakage less crippling by also renaming the config field?
Oh thats true, i didnt consider the config files. Maybe I just leave it as is.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57100/new/

https://reviews.llvm.org/D57100