[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 24 02:41:20 PST 2019
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp:2322
+TEST(CompletionTest, CrashOnNullType) {
+ auto Results = completions(R"cpp(
----------------
kadircet wrote:
> nit: WorksWithNullType ? it doesn't seem like crashing
Indeed, I've been using this naming convention for ages, but I can see why it might be confusing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57093/new/
https://reviews.llvm.org/D57093
More information about the cfe-commits
mailing list