[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers
Bevin Hansson via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 24 00:30:27 PST 2019
ebevhan added a comment.
I think the code that comes to mind is mostly like in `GetTypeSourceInfoForDeclarator`:
LangAS AS =
(ASIdx == LangAS::Default ? LangAS::opencl_generic : ASIdx);
It's behind an OpenCLCPlusPlus guard so it won't add generic on anything if it's not OpenCL++, but there shouldn't be a reason why the rest of the code in that block won't work for regular C++.
In fact, in most regular C++ this would be an issue, since Default typically _is_ the 'generic' address space there.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55850/new/
https://reviews.llvm.org/D55850
More information about the cfe-commits
mailing list