[PATCH] D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 23 17:10:57 PST 2019


vsapsai added a comment.

In D57076#1368407 <https://reviews.llvm.org/D57076#1368407>, @jordan_rose wrote:

> I //think// this is reasonable but Doug was the one who worked on this. I wonder if it also helps with the test cases in rdar://problem/24619481.


Yep, it helps with the test cases in rdar://problem/24619481. As soon as `ObjCObjectType` has `IsKindOf`, `ASTContext::canAssignObjCInterfaces` takes care of everything. It checks that LHS is a superclass of RHS or when RHS has `__kindof` that LHS is a subclass of RHS. My change doesn't deal with inheritance, so I didn't add those test cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57076/new/

https://reviews.llvm.org/D57076





More information about the cfe-commits mailing list