[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 23 12:45:29 PST 2019


Eugene.Zelenko added a comment.

Please mention new module in docs/clang-tidy/index.rst.



================
Comment at: docs/ReleaseNotes.rst:76
 
+- New OpenMP module.
+
----------------
Please put new module before list of new checks.


================
Comment at: docs/ReleaseNotes.rst:83
+
+  Diagnoses directives that are allowed to contain 'default(none)' clause,
+  but don't contain it.
----------------
Please use `` for default(none). Will be good idea to make this statement same as in documentation.


================
Comment at: docs/clang-tidy/checks/openmp-use-default-none.rst:19
+
+
+  // 'for' directive can not have 'default' clause, no diagnostics.
----------------
Unnecessary empty line.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57113/new/

https://reviews.llvm.org/D57113





More information about the cfe-commits mailing list