[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 23 12:40:00 PST 2019


riccibruno accepted this revision.
riccibruno added a comment.
This revision is now accepted and ready to land.

In D57111#1368277 <https://reviews.llvm.org/D57111#1368277>, @rzhikharevich wrote:

> In D57111#1368256 <https://reviews.llvm.org/D57111#1368256>, @riccibruno wrote:
>
> > I guess you will want someone to commit it ?
>
>
> Yes, if the fix is correct.


It looks to be correct to me since the problem is that `LookupDestructor` will dispatch to
`Sema::LookupSpecialMember`, which assumes that the `CXXRecordDecl` has a definition.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57111/new/

https://reviews.llvm.org/D57111





More information about the cfe-commits mailing list