[PATCH] D57111: Make Clang not crash on calls to destructors on incomplete pointer types

Wed Jan 23 12:17:52 PST 2019

riccibruno added a comment.

In D57111#1368230 <https://reviews.llvm.org/D57111#1368230>, @rzhikharevich wrote:

> In D57111#1368224 <https://reviews.llvm.org/D57111#1368224>, @riccibruno wrote:
>
> > Upload patches with full context please.
> >  Also the diagnostic seems to be wrong ?
>
>
> I don't think so, the valid code would be 'p->~C()'.

You are right, my bad!

>> And finally is there a bug report for this ?
> 
> No. Should I file one?

No, it is just so that we can close the corresponding bug report if there is one.
Your fix seems reasonable to me. Thanks for the patch!

I guess you will want someone to commit it ?

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57111/new/

https://reviews.llvm.org/D57111