[PATCH] D57104: [AST] Pack GenericSelectionExpr

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno marked an inline comment as done.
riccibruno added a comment.

In D57104#1368055 <https://reviews.llvm.org/D57104#1368055>, @steveire wrote:

> Splitting the introduction of and porting to `Create` would significantly reduce the number of files touched by the 'real' change in this commit, and therefore reduce noise in the commit (following the idea of "do one thing per commit" to make the code reviewable in the future).
>
> However, if you're opposed to that, it's not a hard requirement.


To be honest I don't really see the point. This is just the usual pattern of having a `Create` function doing the allocation,
which then dispatch to the private constructor with a placement new for the initialization.



================
Comment at: include/clang/AST/Expr.h:5048
+    // are the associated expressions.
+    return 1 + getNumAssocs();
+  }
----------------
steveire wrote:
> Would it be correct to use `ASSOC_EXPR_START` here instead of the magic `1`?
Eh maybe ?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57104/new/

https://reviews.llvm.org/D57104