[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check
Jonas Toth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 23 07:43:14 PST 2019
JonasToth added inline comments.
================
Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:133
+ StringRef Correct =
+ HasFinal ? "'" + FinalMacro + "'" : "'" + OverrideMacro + "'";
----------------
Dangling? These values seem to be temporary and `StringRef` would bind to the temporary, not?
For the concatenation `llvm::Twine` would be better as well, same in the other places.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57087/new/
https://reviews.llvm.org/D57087
More information about the cfe-commits
mailing list