[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

Wed Jan 23 07:42:13 PST 2019

lebedev.ri added a comment.

In D57100#1367817 <https://reviews.llvm.org/D57100#1367817>, @JonasToth wrote:

> In D57100#1367813 <https://reviews.llvm.org/D57100#1367813>, @lebedev.ri wrote:
>
> > 2. It would be great for it to be generalized to not only detect the escaping of exceptions out of functions, but out of "statements" too. Namely, i would love some better handling of openmp directives. I might look into that later.
>
>
> The internals can handle `Stmt` already and do traverse all statements of a `FunctionDecl`, so it should be possible to expose that.
>  Can OpenMP directives throw?

The other way around, it's **the** same problem as with exceptions escaping noexcept functions,
but just with narrower scope - a statement - as opposed to whole function

> I think making this class and its interface is the first step to both features, incremental improvements are then easier to do.

Yep, don't want to drag anything sideways, just voicing some thoughts.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57100/new/

https://reviews.llvm.org/D57100