[PATCH] D57098: [WIP][AST] NFC: Introduce new class GenericSelectionExpr::Association
    Stephen Kelly via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Jan 23 07:31:11 PST 2019
    
    
  
steveire added a comment.
Thanks for doing this!
It would be easier to review (now and in the future!) if you split it into at least 3 commits
- Refactor without changing API to use trailing objects
- The change to use bitfields and Stmt.h
- Introduce new class GenericSelectionExpr::Association
Thanks,
Stephen
Repository:
  rC Clang
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57098/new/
https://reviews.llvm.org/D57098
    
    
More information about the cfe-commits
mailing list