[PATCH] D57093: [CodeComplete] [clangd] Fix crash on ValueDecl with a null type

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 23 05:37:05 PST 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp:2322
 
+TEST(CompletionTest, CrashOnNullType) {
+  auto Results = completions(R"cpp(
----------------
nit: WorksWithNullType ? it doesn't seem like crashing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57093/new/

https://reviews.llvm.org/D57093





More information about the cfe-commits mailing list