[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

[Philip Pfaffe via Phabricator via cfe-commits]

philip.pfaffe added a comment.

I'm not sure what the current state of plugins on windows is. They were broken and disabled last time I worked on this, but that might've changed in the meantime! Worth checking.



================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:292
+  /// List of dynamic shared object files to be loaded as pass plugins.
+  std::vector<std::string> PassPlugins;
+
----------------
melver wrote:
> philip.pfaffe wrote:
> > This  should be SmallVector.
> Not sure if this is better. getAllArgValues returns a vector<string>, which is why I think the above members are also vector<string>. And std::vector cannot be assigned to SmallVector, which required an extra line in CompilerInvocation.cpp.
> 
> Let me know what you think.
You're right, SmallVector doesn't actually help here. Sorry!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56935/new/

https://reviews.llvm.org/D56935