[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

[Vladimir Stefanovic via Phabricator via cfe-commits]

vstefanovic marked an inline comment as done.
vstefanovic added inline comments.


================
Comment at: cfe/trunk/include/clang/Driver/Options.td:2423
+  Group<m_mips_Features_Group>,
+  HelpText<"Try turning PIC calls (j{al}r{c} $25) into direct calls "
+  "(MIPS only)">, Flags<[HelpHidden]>;
----------------
sdardis wrote:
> I think this help text could be a little better. Instead of implying that the compiler could turn PIC calls into direct calls, something like "Produce relaxation hints for linkers to try optimizing PIC call sequences into direct calls", I believe describes the optimization better. Likewise in the negative sense for the -mno-relax-pic-calls.
Hi Simon, I'll replace the text with your version, it's better indeed. Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56878/new/

https://reviews.llvm.org/D56878