[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 22 13:33:39 PST 2019


rsmith added a comment.

In D56723#1366529 <https://reviews.llvm.org/D56723#1366529>, @ilya-biryukov wrote:

> I'll try playing around with your idea, my initial plan is to store preferred type alongside the current token as a member of the `Parser` class and update it when advancing to next token, when the parser backtracks and in the places where we care about propagating the types.


`ConsumeToken` is a fairly hot function; if you can avoid changes there that'd be preferable. Tracking this automatically across tentative parse / rollback seems like a very nice idea.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56723/new/

https://reviews.llvm.org/D56723





More information about the cfe-commits mailing list