[PATCH] D57004: [docs] Add release notes for notable things I've contributed since last release
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 22 10:24:55 PST 2019
rnk added inline comments.
================
Comment at: docs/ReleaseNotes.rst:190
+- For MinGW, clang now produces vtables and RTTI for dllexported classes
+ without key functions.
+
----------------
hans wrote:
> mstorsjo wrote:
> > This comment doesn't really say much for the casual reader, perhaps it should just be left out and regarded as general assorted bugfixes? Although the fix (D55698) is a notable step towards matching GCC better for MinGW, and fixes an actual issue (building Qt in debug mode).
> I think keeping it in is fine. If you want you could of course expand with mentioning the Qt part of your comment and maybe link to a bug entry if applicable.
I agree, I think the info about Qt is the kind of newsworthy thing users will want to know and will understand.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57004/new/
https://reviews.llvm.org/D57004
More information about the cfe-commits
mailing list