[PATCH] D56539: [clangd] Drop documentation in static index if symbols are not indexed for completion.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Just realized I missed this review, sorry about that.
LGTM with a nit.



================
Comment at: clangd/index/FileIndex.cpp:51
     CollectorOpts.RefFilter = RefKind::All;
-  }else {
+    CollectorOpts.StoreAllDocumentation = false;
+  } else {
----------------
NIT: maybe mention the rationale here in a comment? Something like `// comments for main file can always be obtained from sema, do not store them in the index.`


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56539/new/

https://reviews.llvm.org/D56539