[PATCH] D57047: [clangd] Fix broken build after r351793.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 22 06:28:56 PST 2019


ioeric added a comment.

In D57047#1366265 <https://reviews.llvm.org/D57047#1366265>, @kadircet wrote:

> LGTM, but hokein might know better whether to push the default options or the one in ClangdServerOpts


I'm going to land this now to unbreak build. Feel free to comment or do further refactoring if the default is not the best thing to pass here. Currently, this doesn't seem to matter as it's not used in CodeCompletion.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57047/new/

https://reviews.llvm.org/D57047





More information about the cfe-commits mailing list