[PATCH] D57032: [SemaCXX] Param diagnostic matches overload logic

[S. B. Tam via Phabricator via cfe-commits]

cpplearner added inline comments.


================
Comment at: lib/Sema/SemaDecl.cpp:5092
     // The parameter types are identical
-    if (Context.hasSameType(DefParamTy, DeclParamTy))
+    if (Context.hasSameType(DefParamTy.getUnqualifiedType(),
+                            DeclParamTy.getUnqualifiedType()))
----------------
I see this is what `Sema::FunctionParamTypesAreEqual` does, but maybe both places should use `hasSameUnqualifiedType`?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57032/new/

https://reviews.llvm.org/D57032