[PATCH] D56903: [clangd] Suggest adding missing includes for incomplete type diagnostics.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

A drop-by comment.



================
Comment at: clangd/IncludeFixer.cpp:66
+  vlog("Trying to fix include for incomplete type {0}", IncompleteType);
+  FuzzyFindRequest Req;
+  Req.AnyScope = false;
----------------
sammccall wrote:
> limit?
Why do we use fuzzyFind and not `lookup` here?
Are there cases when we can't construct `SymbolID` for the `TagDecl`?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56903/new/

https://reviews.llvm.org/D56903