r351603 - [ASTDump] NFC: Remove non-needed braces

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 18:04:16 PST 2019


(To be clear, your 3 others around the same time are all fine! I mean just
bracing tweaks.)

On Mon, Jan 21, 2019 at 9:03 PM Nico Weber <thakis at chromium.org> wrote:

> Please don't do changes like this. They have marginal utility and make
> blame output more annoying to work with.
>
> On Fri, Jan 18, 2019 at 5:18 PM Stephen Kelly via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: steveire
>> Date: Fri Jan 18 14:14:59 2019
>> New Revision: 351603
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=351603&view=rev
>> Log:
>> [ASTDump] NFC: Remove non-needed braces
>>
>> Modified:
>>     cfe/trunk/lib/AST/ASTDumper.cpp
>>
>> Modified: cfe/trunk/lib/AST/ASTDumper.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=351603&r1=351602&r2=351603&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/AST/ASTDumper.cpp (original)
>> +++ cfe/trunk/lib/AST/ASTDumper.cpp Fri Jan 18 14:14:59 2019
>> @@ -1242,12 +1242,11 @@ void ASTDumper::VisitObjCMethodDecl(cons
>>    if (D->isVariadic())
>>      OS << " variadic";
>>
>> -  if (D->isThisDeclarationADefinition()) {
>> +  if (D->isThisDeclarationADefinition())
>>      dumpDeclContext(D);
>> -  } else {
>> +  else
>>      for (const ParmVarDecl *Parameter : D->parameters())
>>        dumpDecl(Parameter);
>> -  }
>>
>>    if (D->hasBody())
>>      dumpStmt(D->getBody());
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190121/f9e768a9/attachment.html>


More information about the cfe-commits mailing list