[PATCH] D56723: [CodeComplete] Propagate preferred types through parser in more cases

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

This seems to be introducing a requirement that `enterUnknown` is called on all paths through the parser where we recurse to parse a subexpression and don't have specific type information. That seems like an unfortunate requirement to me from a maintenance perspective; have you considered alternative approaches? For example, we could store the preferred type alongside the `SourceLocation` of the corresponding token (and propagate the information when we parse parentheses and any other completion-type-preserving construct), and only apply the information when the code completion token is at that location. That way, we only need to annotate cases where we know the preferred type, not when we don't.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56723/new/

https://reviews.llvm.org/D56723