[PATCH] D56318: [HIP] Fix size_t for MSVC environment
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 21 11:57:10 PST 2019
yaxunl added a comment.
In D56318#1355705 <https://reviews.llvm.org/D56318#1355705>, @rjmccall wrote:
> It's pretty unfortunate that all these fields have to be individually called out like this. Can you move all these basic layout fields into a separate `struct` (which can be a secondary base class of `TargetInfo`) which can then just be normally copied? Anything that needs special copy semantics, like the LLVM `DataLayout` (do you need to copy this?) doesn't need to go into that struct, just the basic POD things that determine fundamental type layouts and semantics.
LLVM DataLayout contains target specific stuff and cannot be simply copied. So far we did not see necessity to adjust device data layout for host.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56318/new/
https://reviews.llvm.org/D56318
More information about the cfe-commits
mailing list