[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a naming convention nit.



================
Comment at: lib/Analysis/ThreadSafety.cpp:984
             StringRef DiagKind) const {
-    if (!FSet.findLock(FactMan, Cp)) {
+    if (const FactEntry *fact = FSet.findLock(FactMan, Cp)) {
+      if (Handler)
----------------
fact -> Fact


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56967/new/

https://reviews.llvm.org/D56967