[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 08:30:35 PST 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a commenting nit, thank you for the cleanup!



================
Comment at: lib/Sema/SemaDeclAttr.cpp:5620
+    S.Diag(D->getLocation(), diag::warn_interrupt_attribute_invalid)
+        << /*Mips*/ 0 << 0;
     return;
----------------
Comment should probably be `MIPS` instead (same below).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57012/new/

https://reviews.llvm.org/D57012





More information about the cfe-commits mailing list