[PATCH] D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 03:04:24 PST 2019


mgorny added a comment.

In D56976#1365001 <https://reviews.llvm.org/D56976#1365001>, @ilya-biryukov wrote:

> LGTM to unbreak the tests on *BSD, but could you please leave a comment?
>  It would probably be best to take `argv[0]` into account on *BSD systems as well (possibly only if `clang` could not be found).
>
> At least if that's the behaviour on **all** other systems.


Actually, it works on other systems because they don't use `argv[0]`. The problem is in compilation db code using getMainExecutable() in ctor without passing the real argv to it.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56976/new/

https://reviews.llvm.org/D56976





More information about the cfe-commits mailing list