[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 17 05:51:36 PST 2019


ymandel added a comment.

In D56786#1360706 <https://reviews.llvm.org/D56786#1360706>, @steveire wrote:

> It seems that you update docs for existing matchers without changing those matchers. You could put all of that in one patch.
>
> Then, you seem to add some tests for existing matches. You could put that in the second patch.
>
> Then your third patch would add the new matcher with its tests and its docs.
>
> That would be easy to review.


Done:
Comments: https://reviews.llvm.org/D56849
Tests: https://reviews.llvm.org/D56850
New matcher with tests: https://reviews.llvm.org/D56851


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56786/new/

https://reviews.llvm.org/D56786





More information about the cfe-commits mailing list