[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 16 15:31:23 PST 2019


steveire added a comment.

It seems that you update docs for existing matchers without changing those matchers. You could put all of that in one patch.

Then, you seem to add some tests for existing matches. You could put that in the second patch.

Then your third patch would add the new matcher with its tests and its docs.

That would be easy to review.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56786/new/

https://reviews.llvm.org/D56786





More information about the cfe-commits mailing list