[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:376
+  case ToolChain::FT_Object:
+    Suffix = Triple.isOSWindows() ? ".obj" : ".o";
+    break;
----------------
For mingw (Triple.isWindowsGNUEnvironment) the natural extension is `.o` as well. So maybe check `IsITANMSVCWindows` instead here?


================
Comment at: clang/lib/Driver/ToolChain.cpp:383
+    Suffix = Triple.isOSWindows()
+                 ? (Triple.isWindowsGNUEnvironment() ? ".dll.a" : ".dll")
+                 : ".so";
----------------
This looks like it's incorrectly rebased across rL343537; the non-mingw case should be `.lib`, not `.dll` - that was corrected in that commit.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56044/new/

https://reviews.llvm.org/D56044