[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 31 17:27:59 PST 2018


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

OK, that makes sense. I'm not a huge fan of how this set of code looks, but it also seems unfair to require you to extensively refactor it for this.

Any issues with crtbegin/end and where people believe things should be implemented for any given OS is orthogonal to this.

Thanks!

-eric


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56044/new/

https://reviews.llvm.org/D56044





More information about the cfe-commits mailing list