[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Bevin Hansson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 17 15:37:10 PST 2018


ebevhan added a comment.

I'm also a bit confused about the semantics that this patch is applying to function types. It mostly seems to concern the extra trailing Qualifiers on CXXMethodDecl to store the addrspace quals, but in some places (SemaType:4842, SemaDecl:3198) it seems to be applying the address space to the function type itself, which certainly seems like something else to me. A function with an address space qualified type would (to me, at least) be a function *located* in that address space, not one qualified to take a `this` from that address space.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54862/new/

https://reviews.llvm.org/D54862





More information about the cfe-commits mailing list