[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 17 12:10:29 PST 2018
rjmccall added inline comments.
================
Comment at: lib/CodeGen/CGCall.cpp:77
+ if (MD)
+ RecTy = Context.getAddrSpaceQualType(RecTy, MD->getType().getAddressSpace());
return Context.getPointerType(CanQualType::CreateUnsafe(RecTy));
----------------
ebevhan wrote:
> I'm a bit late to the party, but shouldn't this be `MD->getTypeQualifiers().getAddressSpace()`?
Yes, you're right, it should.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54862/new/
https://reviews.llvm.org/D54862
More information about the cfe-commits
mailing list