[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

Thu Dec 13 14:38:28 PST 2018

rnk added a comment.

In D55672#1330460 <https://reviews.llvm.org/D55672#1330460>, @rjmccall wrote:

> Thanks.  I think you missed these, though:
>
> - a template argument that's just a function type, not a function pointer or reference type

I think useTemplateFnType is supposed to handle that case.

In D55672#1330462 <https://reviews.llvm.org/D55672#1330462>, @rjmccall wrote:

> Tests are good!  Also, we do mangle more things from a function template specialization, like the return type and other things that might trigger SFINAE conditions; it's not the same code path.

Fair enough, hopefully these are what you had in mind.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55672/new/

https://reviews.llvm.org/D55672