[PATCH] D55672: Mangle calling conventions into function pointer types where GCC does

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In D55672#1330458 <https://reviews.llvm.org/D55672#1330458>, @rnk wrote:

> In D55672#1330402 <https://reviews.llvm.org/D55672#1330402>, @rnk wrote:
>
> > - a specialization of a function template that happens to be declared with this calling convention (this also probably shouldn't include the CC in the mangling, but it's okay to match GCC if it does)
>
>
> I didn't add a test for this special case, since we don't mangle ccs into normal functions. I don't think making a function specialization template is likely to cause us to suddenly emit the convention.


Tests are good!  Also, we do mangle more things from a function template specialization, like the return type and other things that might trigger SFINAE conditions; it's not the same code path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55672/new/

https://reviews.llvm.org/D55672