[PATCH] D54995: [MemoryBuffer] Add the setter to be able to force disabled mmap

[Zachary Turner via Phabricator via cfe-commits]

zturner added a comment.

Assuming this patch were to go in as-is (which it probably won't, based on the feedback, but let's just pretend), that would avoid having to explicitly update how many callsites?

What I'm wondering is, how hard would it be to just update the call-sites?

It looks like what you are really trying to do is avoid having to pass "IsVolatile" for many call-sites.  But to be honest, IsVolatile exactly describes this situation.  You have a file, and another program has the same file and it can change it out from underneath you.  That exactly describes the meaning of `IsVolatile`.  So, conceptually it makes sense to just find all the call-sites where this matters and pass `IsVolatile=true`.  Is there some reason we can't just do that here?  Are there too many?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995